Skip to content

Make test and benchmark durations configurable #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bugparty merged 2 commits into from
Jun 7, 2025
Merged

Make test and benchmark durations configurable #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6087486
Make benchmark and test durations configurable
bugparty Jun 7, 2025
44ebdc6
Merge branch 'main' into codex/configure-cmake-variable-for-test-time
bugparty Jun 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@ cmake_minimum_required(VERSION 3.21)
project(bitvector)

set(CMAKE_CXX_STANDARD 17)

# Allow configuring how long tests may run and how long benchmarks
# should execute. The timeout for GoogleTest-based unit tests is set via
# `BITVECTOR_TEST_TIMEOUT`. The minimum runtime for Google Benchmark
# benchmarks is configured with `BITVECTOR_BENCHMARK_MIN_TIME`.
set(BITVECTOR_TEST_TIMEOUT 10 CACHE STRING "Timeout in seconds for each unit test")
set(BITVECTOR_BENCHMARK_MIN_TIME 0.2 CACHE STRING "Minimum time in seconds for benchmark runs")
option(BITVECTOR_NO_BOUND_CHECK "Disable bounds checking in bitvector" ON)
if(BITVECTOR_NO_BOUND_CHECK)
add_compile_definitions(BITVECTOR_NO_BOUND_CHECK)
Expand Down Expand Up @@ -78,6 +85,7 @@ target_link_libraries(bitvector_tests GTest::gtest_main)
# Benchmark target
add_executable(bitvector_benchmark bitvector_benchmark.cpp)
target_link_libraries(bitvector_benchmark benchmark::benchmark)
target_compile_definitions(bitvector_benchmark PRIVATE BITVECTOR_BENCHMARK_MIN_TIME=${BITVECTOR_BENCHMARK_MIN_TIME})


# Link your project with Google Test (only for test purposes)
Expand All @@ -91,5 +99,5 @@ target_link_libraries(bitvector_benchmark benchmark::benchmark)

# Enable test discovery
include(GoogleTest)
gtest_discover_tests(bitvector_tests)
gtest_discover_tests(bitvector_tests PROPERTIES TIMEOUT ${BITVECTOR_TEST_TIMEOUT})

28 changes: 16 additions & 12 deletions bitvector_benchmark.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
#include <benchmark/benchmark.h>
#include <vector>

#ifndef BITVECTOR_BENCHMARK_MIN_TIME
#define BITVECTOR_BENCHMARK_MIN_TIME 0.2
#endif

using bowen::bitvector;

static void BM_Bowen_Set(benchmark::State& state) {
Expand Down Expand Up @@ -143,17 +147,17 @@ static void BM_Std_IncrementUntilZero(benchmark::State& state) {
}
}

BENCHMARK(BM_Bowen_Set)->Arg(1<<20)->MinTime(5.0);
BENCHMARK(BM_Std_Set)->Arg(1<<20)->MinTime(5.0);
BENCHMARK(BM_Bowen_PushBack)->Arg(1<<20)->MinTime(5.0);
BENCHMARK(BM_Std_PushBack)->Arg(1<<20)->MinTime(5.0);
BENCHMARK(BM_Bowen_Access)->Arg(1<<20)->MinTime(5.0);
BENCHMARK(BM_Std_Access)->Arg(1<<20)->MinTime(5.0);
BENCHMARK(BM_Bowen_SetBitTrue6)->Arg(1<<20)->MinTime(5.0);
BENCHMARK(BM_Std_SetBitTrue6)->Arg(1<<20)->MinTime(5.0);
BENCHMARK(BM_Bowen_QSetBitTrue6V2)->Arg(1<<20)->MinTime(5.0);
BENCHMARK(BM_Std_QSetBitTrue6)->Arg(1<<20)->MinTime(5.0);
BENCHMARK(BM_Bowen_IncrementUntilZero)->Arg(1<<20)->MinTime(5.0);
BENCHMARK(BM_Std_IncrementUntilZero)->Arg(1<<20)->MinTime(5.0);
BENCHMARK(BM_Bowen_Set)->Arg(1<<20)->MinTime(BITVECTOR_BENCHMARK_MIN_TIME);
BENCHMARK(BM_Std_Set)->Arg(1<<20)->MinTime(BITVECTOR_BENCHMARK_MIN_TIME);
BENCHMARK(BM_Bowen_PushBack)->Arg(1<<20)->MinTime(BITVECTOR_BENCHMARK_MIN_TIME);
BENCHMARK(BM_Std_PushBack)->Arg(1<<20)->MinTime(BITVECTOR_BENCHMARK_MIN_TIME);
BENCHMARK(BM_Bowen_Access)->Arg(1<<20)->MinTime(BITVECTOR_BENCHMARK_MIN_TIME);
BENCHMARK(BM_Std_Access)->Arg(1<<20)->MinTime(BITVECTOR_BENCHMARK_MIN_TIME);
BENCHMARK(BM_Bowen_SetBitTrue6)->Arg(1<<20)->MinTime(BITVECTOR_BENCHMARK_MIN_TIME);
BENCHMARK(BM_Std_SetBitTrue6)->Arg(1<<20)->MinTime(BITVECTOR_BENCHMARK_MIN_TIME);
BENCHMARK(BM_Bowen_QSetBitTrue6V2)->Arg(1<<20)->MinTime(BITVECTOR_BENCHMARK_MIN_TIME);
BENCHMARK(BM_Std_QSetBitTrue6)->Arg(1<<20)->MinTime(BITVECTOR_BENCHMARK_MIN_TIME);
BENCHMARK(BM_Bowen_IncrementUntilZero)->Arg(1<<20)->MinTime(BITVECTOR_BENCHMARK_MIN_TIME);
BENCHMARK(BM_Std_IncrementUntilZero)->Arg(1<<20)->MinTime(BITVECTOR_BENCHMARK_MIN_TIME);

BENCHMARK_MAIN();