Fix pending state being used incorrectly, ignore ThrottlingException error, accept more options#137
Open
itsmepetrov wants to merge 6 commits intobugcrowd:mainfrom
Open
Fix pending state being used incorrectly, ignore ThrottlingException error, accept more options#137itsmepetrov wants to merge 6 commits intobugcrowd:mainfrom
itsmepetrov wants to merge 6 commits intobugcrowd:mainfrom
Conversation
Author
|
@ohookins could you please review it |
Contributor
|
@itsmepetrov thanks for the contribution! It's been a bit busy recently but I will review it soon :) |
Author
|
@ohookins any news? |
ohookins
approved these changes
Nov 21, 2025
Contributor
|
@itsmepetrov thanks for your contribution! It seems like this repo has some settings which aren't compatible with external contributions so I need to get them fixed before I can merge your PR. Unless you want to go back and sign your commits? |
Contributor
|
Actually I probably do need you to sign the commits, if that's ok. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
This PR fixes two issues:
ThrottlingException, get logs calls have a hard limit, and they don't qualify for a limit increase in AWS, so having two, three... tasks running simultaneously could cause the error quickly, the easiest way just to ignore it as it do not affect anything.I've also added configuration for
durationBetweenPollsandtimeoutBeforeFirstLogs