-
Notifications
You must be signed in to change notification settings - Fork 0
feat(cli): add skill command for SKILL.md generation #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phase 1 of generate-skill CLI command implementation: - Create mcp-skill crate with skill generation logic - Move parser, context, template modules from mcp-server - Add validate_server_id() and extract_skill_metadata() functions - Apply performance fixes (LazyLock for Handlebars template) - Apply security fixes (path canonicalization, symlink protection) - Add DoS protection tests (TooManyFiles, FileTooLarge) - Reduce code duplication between crates All 564 tests passing.
Add CLI command to generate Claude Code skill files from progressive loading TypeScript files. Key features: - Parse JSDoc metadata (@tool, @server, @category, @Keywords, @description) - Build skill context with automatic categorization and examples - Multi-layer security: path traversal, symlink, DoS protection - Refactor main.rs to modular cli.rs/runner.rs structure The skill command outputs a structured prompt suitable for LLM-based SKILL.md generation. For optimal results, MCP server is recommended as it can leverage LLM summarization for more concise output.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## master #40 +/- ##
==========================================
+ Coverage 92.41% 92.80% +0.38%
==========================================
Files 21 22 +1
Lines 4749 4779 +30
==========================================
+ Hits 4389 4435 +46
+ Misses 360 344 -16
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
Contains breaking API changes (requires major version bump)
build
Build configuration changes (build.rs, toolchain)
crate: mcp-cli
Changes to mcp-cli crate (command-line interface)
release
Release preparation (changelog, version bumps)
type: dependencies
Dependency updates (Cargo.toml, Cargo.lock)
type: documentation
Documentation changes (*.md, docs/, comments)
workspace
Workspace-wide changes affecting multiple crates
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
skillCLI command to generate Claude Code skill files (SKILL.md) from progressive loading TypeScript filesmain.rsinto modularcli.rs/runner.rsstructure for better maintainabilitymcp-skillREADME with proper MSRV documentation and GitHub calloutsChanges
New Features
mcp-execution-cli skillcommand with options:--server, -s- Server identifier (required)--servers-dir- Custom servers directory--output, -o- Custom output path--skill-name- Custom skill name--hint- Use case hints (repeatable)--overwrite- Overwrite existing SKILL.mdSecurity
Component::ParentDiranalysiscanonicalize()+starts_with()validationCode Quality
main.rsinto focused modulesTest Plan