feat(cli): add --from-config support to introspect command #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the ability to load server configuration from ~/.claude/mcp.json when using the introspect command, matching existing functionality in the generate command. Changes: - Add --from-config flag to introspect command in main.rs - Update introspect::run() to support config loading - Apply security improvements to error messages - Change config loading logs from info! to debug! level - Update all existing tests for new function signature - Bump dependency versions (handlebars, rmcp, schemars, tempfile, tokio) Security improvements: - Remove server list from "not found" error messages - Use user-friendly path (~/.claude/mcp.json) in error messages
github-actions
bot
added
crate: mcp-cli
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## master #39 +/- ##
=======================================
Coverage 92.41% 92.41%
=======================================
Files 21 21
Lines 4749 4749
=======================================
Hits 4389 4389
Misses 360 360
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Add 3 tests for introspect --from-config functionality: - test_run_from_config_not_found: config error handling - test_run_from_config_takes_priority: config path selection - test_run_manual_mode_backward_compatible: backward compat
Add Configuration Modes section and examples showing --from-config usage, matching generate command documentation.
- Update version from 0.6.2 to 0.6.3 in Cargo.toml - Add CHANGELOG entry for --from-config introspect feature - Add diff links to all CHANGELOG releases - Expand introspect documentation in mcp-cli README - Fix config path inconsistency (~/.claude/mcp.json) - Update README CLI commands section with v0.6.3 examples
github-actions
bot
added
type: documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
--from-configflag to theintrospectcommand, enabling users to load server configuration from~/.claude/mcp.jsoninstead of specifying command/args manually.--from-config <NAME>argument to introspect commandload_server_from_config()function from generate commandExample Usage
Test plan
cargo clippy --workspace -- -D warningspassescargo +nightly fmt --checkpassesFiles Changed
crates/mcp-cli/src/main.rs- CLI argument definitions and help textcrates/mcp-cli/src/commands/introspect.rs- Config loading logic + testscrates/mcp-cli/src/commands/common.rs- Security improvements to error messagescrates/mcp-cli/src/commands/generate.rs- Logging level consistencyCargo.toml,Cargo.lock- Dependency updates