Lint MessageRules.oneof in PROTOVALIDATE check#4540
Merged
Conversation
Validate that each MessageOneofRule entry names at least one field, contains no duplicate names, references only fields defined in the message, and that no field appears in more than one entry.
Contributor
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
doriable
approved these changes
May 12, 2026
Member
doriable
left a comment
doriable
left a comment
There was a problem hiding this comment.
This makes sense to me -- I know there's a lint exception that needs to be added for the int32 conversion for field tags, approving in advance of that. Super tiny note: do you mind adding a changelog entry for this?
Member
Author
Sorry it took me so long to get back to this. Fixed the lint rule and also added the changelog entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate that each MessageOneofRule entry names at least one field, contains no duplicate names, references only fields defined in the message, and that no field appears in more than one entry.