fix: release foreground bash shells after completion#135
Open
Andy963 wants to merge 1 commit intobubbuild:mainfrom
Open
fix: release foreground bash shells after completion#135Andy963 wants to merge 1 commit intobubbuild:mainfrom
Andy963 wants to merge 1 commit intobubbuild:mainfrom
Conversation
frostming
reviewed
Mar 25, 2026
| raise KeyError(f"unknown shell id: {shell_id}") from exc | ||
|
|
||
| def release(self, shell_id: str) -> ManagedShell | None: | ||
| return self._shells.pop(shell_id, None) |
Collaborator
There was a problem hiding this comment.
Seems it can be moved into wait_closed to make it cleaner, since wait_closed will be called on all paths
Contributor
Author
There was a problem hiding this comment.
Not exactly. The timeout path goes through terminate(), not wait_closed(), so wait_closed() is not called on all paths. This change is intentionally scoped to fixing foreground shell cleanup. Background shell cleanup is a separate concern, and I'm not sure yet where that cleanup should happen, since we haven't defined the lifecycle for completed background shells.
Collaborator
There was a problem hiding this comment.
Aha, yes, then move to _finalize_shell
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Foreground
bashcommands are now released fromShellManagerafter completion, preventing finished shells (and their buffered stdout/stderr) from being retained in memory in long-running Bub processes (e.g.chat/gateway).Changes
ShellManager.release(shell_id)to remove a shell from the internal registry.bashalways callsrelease()in afinallyblock (success, non-zero exit, timeout)._shellsafter execution (including failure).Notes
bash.output/bash.kill).Verification
uv run ruff check .uv run mypy srcuv run pytest -q