[Fix test] "Expiration (exp) time must be a unix time stamp" on 32-bit platform#899
Open
afilippov1985 wants to merge 2 commits intobshaffer:mainfrom
Open
[Fix test] "Expiration (exp) time must be a unix time stamp" on 32-bit platform#899afilippov1985 wants to merge 2 commits intobshaffer:mainfrom
afilippov1985 wants to merge 2 commits intobshaffer:mainfrom
Conversation
Owner
|
Thanks, I did not really test this library for 32 bit. My deepest regrets that you are dealing with such. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After this PR #898 I able to run tests. And I get:
Tests failed because
ctype_digit($jwt['exp'])evals tofalsewhen$jwt['exp']isdouble(it becomesdoublewhen$jwt['exp'] > PHP_INT_MAX)To fix this we should always write big integers as strings (
'99999999900')or write integers as integers (
12345) and integers must be <= PHP_INT_MAX