fix(security): validate upload paths to prevent file exfiltration (PM…#296
Merged
gaurav-singh-9227 merged 1 commit intoMay 18, 2026
Conversation
…AA-107) All four file-upload paths (testmanagement uploadFile, applive uploadApp, appautomate uploadApp, and the shared uploadFileToBrowserStack helper used by Espresso/XCUITest) previously only checked `fs.existsSync` before streaming the file to BrowserStack cloud. A prompt-injected LLM turn could exfiltrate arbitrary user-readable files (SSH keys, .env, credentials). Adds a shared `validateUploadPath` utility that canonicalizes the path via `realpathSync`, enforces a per-call extension allowlist, caps file size (4 GB for apps to match BrowserStack's upload limit, 100 MB for TM attachments), blocks hidden-directory traversal (`.ssh`, `.aws`, `.env`, etc.), and optionally enforces containment inside `MCP_UPLOAD_BASE_DIR` when configured. Covers CWE-22 / CWE-434 / OWASP A01:2025. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
gaurav-singh-9227
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…AA-107)
All four file-upload paths (testmanagement uploadFile, applive uploadApp, appautomate uploadApp, and the shared uploadFileToBrowserStack helper used by Espresso/XCUITest) previously only checked
fs.existsSyncbefore streaming the file to BrowserStack cloud. A prompt-injected LLM turn could exfiltrate arbitrary user-readable files (SSH keys, .env, credentials).Adds a shared
validateUploadPathutility that canonicalizes the path viarealpathSync, enforces a per-call extension allowlist, caps file size (4 GB for apps to match BrowserStack's upload limit, 100 MB for TM attachments), blocks hidden-directory traversal (.ssh,.aws,.env, etc.), and optionally enforces containment insideMCP_UPLOAD_BASE_DIRwhen configured.Covers CWE-22 / CWE-434 / OWASP A01:2025.