Split out unused chrome.debugger behavior into separate class so ModCDPServer gets simpler#7
Open
pirate wants to merge 1 commit into
Open
Split out unused chrome.debugger behavior into separate class so ModCDPServer gets simpler#7pirate wants to merge 1 commit into
chrome.debugger behavior into separate class so ModCDPServer gets simpler#7pirate wants to merge 1 commit into
Conversation
chrome.debugger behavior into separate class so ModCDPServer gets simpler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Splits the service-worker server upstream path into explicit transport classes so ModCDPServer no longer owns loopback-vs-chrome.debugger branching after setup.
This PR includes:
ServerUpstreamTransportbase class + plusLoopbackandDebuggerimplementationsModCDPServerdirectlyAutoSessionRouterValidation
pnpm exec tsc -p tsconfig.json --noEmitpnpm run buildpnpm exec vitest run js/test/test.ServerUpstreamTransport.ts js/test/test.ReverseWebSocketUpstreamTransport.ts js/test/test.NatsUpstreamTransport.ts --fileParallelism=false --maxWorkers=1pnpm exec prek run --all-files