fix(agg/and+or): unwrap union values before bool aggregation#6899
Closed
SAY-5 wants to merge 1 commit into
Closed
Conversation
Closes brimdata#6896. Closes brimdata#6895. `And.Consume` and `Or.Consume` checked `super.TypeUnder(val.Type())` to allow union(bool|...) inputs but still called `val.Bool()` on the union-wrapped value, which decoded the union tag bytes instead of the underlying bool. The result was that `or(this)` over rows like `false::(bool|null)` and `true::(bool|int64)` returned null in the sequential runtime even though the vector runtime returned `true`. Unwrap with `.Under()` first, then validate the underlying type and null-ness, then read `.Bool()`. Same change applies to both aggregators.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6896. Closes #6895.
And.ConsumeandOr.Consumecheckedsuper.TypeUnder(val.Type())to allowunion(bool|…)inputs but still readval.Bool()on the union-wrapped value. That decoded the union tag bytes rather than the underlying bool, so the sequential runtime collapsed mixed-union rows tonulleven when the vector runtime correctly returned the boolean OR/AND.Repro from #6896
Before:
After:
The vector runtime already unwraps before evaluation (
-vamreturnedtrue).Patch
Unwrap with
.Under()first, then guard onIsNull()/val.Type() != TypeBoolagainst the unwrapped value, then read.Bool(). Same change applies to bothAndandOr.ConsumeAsPartialalready routes throughConsume, so partial aggregation paths are covered.Tests: