Skip to content

varexporter compatibility + fix phpunit deprecations #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BenMorel merged 2 commits into from
Mar 9, 2026
Merged

varexporter compatibility + fix phpunit deprecations #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f36243
varexporter compatibility + fix phpunit deprecations
Mar 9, 2026
ac118a3
formatting fix
Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"license": "MIT",
"require": {
"php": "^8.1",
"brick/varexporter": "^0.3.7 || ^0.4.0 || ^0.5.0"
"brick/varexporter": "^0.3.7 || ^0.4.0 || ^0.5.0 || ^0.6.0 || ^0.7.0"
},
"require-dev": {
"phpunit/phpunit": "^10.5",
Expand All @@ -25,4 +25,4 @@
"Brick\\Reflection\\Tests\\": "tests/"
}
}
}
}
12 changes: 6 additions & 6 deletions tests/ReflectionToolsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ public function testGetProperties(string $class, array $expected): void
self::assertSame($expected, $actual);
}

public function hierarchyTestProvider(): array
public static function hierarchyTestProvider(): array
{
return [
['A', [
Expand Down Expand Up @@ -126,7 +126,7 @@ public function testExportFunctionSignature(ReflectionMethod $method, string $ex
self::assertSame($expectedFunctionSignature, $tools->exportFunctionSignature($method));
}

public function providerExportFunction(): Generator
public static function providerExportFunction(): Generator
{
$classes = [
PHP80::class,
Expand All @@ -147,7 +147,7 @@ public function providerExportFunction(): Generator
$reflectionAttributes,
);

$expectFunctionSignature = $this->matchExpectFunctionSignature($expectFunctionSignatures);
$expectFunctionSignature = self::matchExpectFunctionSignature($expectFunctionSignatures);

yield [$reflectionMethod, $expectFunctionSignature->functionSignature];
}
Expand All @@ -157,18 +157,18 @@ public function providerExportFunction(): Generator
/**
* @param ExpectFunctionSignature[] $expectFunctionSignatures
*/
private function matchExpectFunctionSignature(array $expectFunctionSignatures): ExpectFunctionSignature
private static function matchExpectFunctionSignature(array $expectFunctionSignatures): ExpectFunctionSignature
{
foreach ($expectFunctionSignatures as $expectFunctionSignature) {
if ($this->phpMatchesVersionConstraint($expectFunctionSignature->phpVersionConstraint)) {
if (self::phpMatchesVersionConstraint($expectFunctionSignature->phpVersionConstraint)) {
return $expectFunctionSignature;
}
}

throw new Exception('No ExpectFunctionSignature attribute found matching current PHP version');
}

private function phpMatchesVersionConstraint(?string $versionConstraint): bool
private static function phpMatchesVersionConstraint(?string $versionConstraint): bool
{
if ($versionConstraint === null) {
return true;
Expand Down