UI update

[piaudonn]

Fixes #492
Fixes #489 (keep the variable set to - but doesn't prompt for it)

[piaudonn]

I did all that using notepad. It took a while to get it right. Still need to do testing...

[piaudonn]

Oh interesting, we cannot set the publicNetworkAccess to Disabled at installation time else the function cannot be deployed:

{"code":"DeploymentFailed","message":"At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/arm-deployment-operations for usage details.","details":[{"code":"BadRequest","message":"{\r\n  \"Code\": \"BadRequest\",\r\n  \"Message\": \"Creation of storage file share failed with: 'The remote server returned an error: (403) Forbidden.'. Please check if the storage account is accessible.\",\r\n  \"Target\": null,\r\n  \"Details\": [\r\n    {\r\n      \"Message\": \"Creation of storage file share failed with: 'The remote server returned an error: (403) Forbidden.'. Please check if the storage account is accessible.\"\r\n    },\r\n    {\r\n      \"Code\": \"BadRequest\"\r\n    },\r\n    {\r\n      \"ErrorEntity\": {\r\n        \"ExtendedCode\": \"99022\",\r\n        \"MessageTemplate\": \"Creation of storage file share failed with: '{0}'. Please check if the storage account is accessible.\",\r\n        \"Parameters\": [\r\n          \"The remote server returned an error: (403) Forbidden.\"\r\n        ],\r\n        \"Code\": \"BadRequest\",\r\n        \"Message\": \"Creation of storage file share failed with: 'The remote server returned an error: (403) Forbidden.'. Please check if the storage account is accessible.\"\r\n      }\r\n    }\r\n  ],\r\n  \"Innererror\": null\r\n}"}]}

I'll only add the blob part

[piaudonn]

I wonder if all that is event worth it. Shouldnt we disable public blob storage in the template with no choice period? @briandelmsft what do you think?

[briandelmsft]

@piaudonn is there any downside?

[piaudonn]

I don't think there is. I'm not even sure why it's not even the default setting when creating a storage account. I'll ask some Azure core folks if they are aware of challenges of doing that while being used with Function Apps.

[piaudonn]

It seems that it is just not required at all. I close this PR and do another one.
Are we okay of not exposing the URL for MCAS an instead hardcoding it to "-"?

[briandelmsft]

@piaudonn all the docs seem to say that if you want to restrict the storage account then you can't use the standard consumption plan. I think that the current config is an exception because we're loading the code from the web based zip file. I don't know if that will ever change. Do you see any docs that see this config is supported?

As for the MCAS piece, the exposure_module branch already has that removed completely from the deployment

[piaudonn]

Closing this one. Adding suggested change to the exposure_module branch instead.