Added new races from 7.3.5 & Partial support in BFA for Azerite #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjdean1994
reviewed
Jan 31, 2018
mjdean1994
left a comment
mjdean1994
left a comment
There was a problem hiding this comment.
I don't mean to be pedantic, but the tabbing is off for added races. Doesn't seem like a big ask for the sake of code readability.
Collaborator
|
Please could you tidy up indenting not only in Explorers/Models/Character.cs but also in Explorers.Test/GuildTests.cs Makes it easier for others. |
LairdStreak
approved these changes
Jan 31, 2018
Collaborator
LairdStreak
left a comment
LairdStreak
left a comment
There was a problem hiding this comment.
LGTM Merge at your discretion.
Blizzard API now requires TLS12
jsassner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.