Skip to content

Add support to specify a storage class for brainstore readers and #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
KevinGreen wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add support to specify a storage class for brainstore readers and #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions braintrust/templates/brainstore-reader-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,16 @@ spec:
resources:
requests:
storage: {{ required "brainstore.reader.volume.size must be set" .Values.brainstore.reader.volume.size | quote }}
{{- else if .Values.brainstore.reader.volume.ephemeralVolumeStorageClassName }}
ephemeral:
volumeClaimTemplate:
spec:
volumeMode: Filesystem
accessModes: ["ReadWriteOnce"]
storageClassName: {{ .Values.brainstore.reader.volume.ephemeralVolumeStorageClassName }}
resources:
requests:
storage: {{ required "brainstore.reader.volume.size must be set" .Values.brainstore.reader.volume.size | quote }}
{{- else }}
emptyDir: {}
{{- end }}
Expand Down
10 changes: 10 additions & 0 deletions braintrust/templates/brainstore-writer-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,16 @@ spec:
resources:
requests:
storage: {{ required "brainstore.writer.volume.size must be set" .Values.brainstore.writer.volume.size | quote }}
{{- else if .Values.brainstore.writer.volume.ephemeralVolumeStorageClassName }}
ephemeral:
volumeClaimTemplate:
spec:
volumeMode: Filesystem
accessModes: ["ReadWriteOnce"]
storageClassName: {{ .Values.brainstore.writer.volume.ephemeralVolumeStorageClassName }}
resources:
requests:
storage: {{ required "brainstore.writer.volume.size must be set" .Values.brainstore.writer.volume.size | quote }}
{{- else }}
emptyDir: {}
{{- end }}
Expand Down
7 changes: 5 additions & 2 deletions braintrust/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,8 +169,10 @@ brainstore:
# Optional: Volume configuration for cache storage
# When not set, uses default emptyDir: {} (backward compatible)
volume:
# Storage size for ephemeral storage requests (used with GKE Autopilot local SSDs)
# Storage size for ephemeral storage requests
size: ""
# Storage class for ephemeral storage requests
ephemeralVolumeStorageClassName: ""
extraEnvVars: []
nodeSelector: {}
tolerations: []
Expand Down Expand Up @@ -206,8 +208,9 @@ brainstore:
# When not set, uses default emptyDir: {} (backward compatible)
volume:
# Storage size for ephemeral storage requests
# Used with GKE Autopilot local SSDs and Azure Container Storage CSI
size: ""
# Storage class for ephemeral storage requests
ephemeralVolumeStorageClassName: ""
extraEnvVars: []
# Example:
# - name: MY_ENV_VAR
Expand Down