Fix test_login_with_invalid_api_key leaking login thread #73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Intermittent test failures with
WebMock::NetConnectNotAllowedErrorand "terminated with exception" messages appearing during test runs.Cause
test_login_with_invalid_api_keycreated aStatewithout anorg_id, which spawns a background login thread. When the VCR cassette was ejected after the test completed, the orphaned thread (still retrying with exponential backoff) would wake up and attempt a real HTTP request, triggering WebMock errors.Solution
minitest-stub_any_instancegem for instance method stubbingmock_login_in_threadtest helper that:login_in_threadto prevent background thread from spawningThis follows the pattern established in PRs #65 and #68 for handling background thread isolation in tests.