Skip to content

chore: declare node engine requirements#2066

Closed
Abhijeet Prasad (AbhiPrasad) wants to merge 1 commit into
mainfrom
abhi-chore-pin-node-engines
Closed

chore: declare node engine requirements#2066
Abhijeet Prasad (AbhiPrasad) wants to merge 1 commit into
mainfrom
abhi-chore-pin-node-engines

Conversation

@AbhiPrasad
Copy link
Copy Markdown
Member

Make it clear that we support Node 20+ in the JS SDK

Copy link
Copy Markdown
Member

@lforst Luca Forstner (lforst) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change gives me a feel of dread - sorry that it comes so late. Every time we did this in the past, even if we thought it should be fine, people ended up complaining.

I am wondering whether for now we should just document a minimum version requirement and only add the engine with the next major?

Copy link
Copy Markdown
Collaborator

@Qard Stephen Belanger (Qard) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regardless of potential user impact, I would generally always consider the change of a minimum installable version to be a major change. Is there any reason not to just do a major now or soon-ish? The change itself LGTM, just a question of when to ship it?

@AbhiPrasad
Copy link
Copy Markdown
Member Author

I am wondering whether for now we should just document a minimum version requirement and only add the engine with the next major?

yeah I'm fine with doing that. I updated #1841

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants