chore: declare node engine requirements#2066
chore: declare node engine requirements#2066Abhijeet Prasad (AbhiPrasad) wants to merge 1 commit into
Conversation
Luca Forstner (lforst)
left a comment
There was a problem hiding this comment.
This change gives me a feel of dread - sorry that it comes so late. Every time we did this in the past, even if we thought it should be fine, people ended up complaining.
I am wondering whether for now we should just document a minimum version requirement and only add the engine with the next major?
Stephen Belanger (Qard)
left a comment
There was a problem hiding this comment.
Regardless of potential user impact, I would generally always consider the change of a minimum installable version to be a major change. Is there any reason not to just do a major now or soon-ish? The change itself LGTM, just a question of when to ship it?
yeah I'm fine with doing that. I updated #1841 |
Make it clear that we support Node 20+ in the JS SDK