remove baseUrl from tsconfig #368
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| { | ||
| "compilerOptions": { | ||
| "baseUrl": ".", | ||
| "target": "es2015", | ||
| "lib": [ |
There was a problem hiding this comment.
This tsconfig still declares paths mappings (e.g., @lib/*) but baseUrl was removed, and TypeScript requires baseUrl to be set whenever paths is present. Running tsc/Next build in apis/vercel will now fail with Option 'paths' cannot be used without specifying 'baseUrl', breaking alias resolution and the build.
Useful? React with 👍 / 👎.
| "target": "ES2018", | ||
| "strict": true, | ||
| "moduleResolution": "node", | ||
| "baseUrl": ".", | ||
| "paths": { |
There was a problem hiding this comment.
The proxy tsconfig retains paths entries but no longer sets baseUrl; TypeScript rejects paths without baseUrl, so tsc -p packages/proxy/tsconfig.json will now emit Option 'paths' cannot be used without specifying 'baseUrl' and fail to build, breaking the module aliases defined here.
Useful? React with 👍 / 👎.
When baseUrl is removed, TypeScript requires paths to start with ./ to be recognized as relative paths. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
After removing baseUrl, bare imports like `import from "utils"` need explicit path aliases to resolve correctly. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
No description provided.