Open
Conversation
I had a hard time tracking a bug that came from using nvm 18 ( braid-http is using Blob which is only available on node 20 )
Member
|
Oh, I see. Thanks for finding this. I feel the pain of having it not work. I think we should just switch to the older more-compatible API (buffer or typed array) so that people don't even run into this bug and we don't need the warning. Looking into it. |
Contributor
|
I have checked in fixes that should make it work in node 18 (and 16) -- it seems that 18 does have Blob, but "crypto" is not available without requiring it, and the version of crypto in 16 has some functions in some different places. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a hard time tracking a bug that came from using nvm 18 ( braid-http is using Blob which is only available on node 20 )