-
Notifications
You must be signed in to change notification settings - Fork 343
feat(content-sidebar): FF integration for HITL #4441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Denis Marusevich seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
WalkthroughAdds a confidence-score feature flag check ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 🧹 Recent nitpick comments
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/elements/content-sidebar/__tests__/MetadataSidebarRedesign.test.tsx`:
- Around line 277-285: The tests are double-nesting feature flags because
renderComponent already wraps the second arg into { wrapperProps: { features }
}, so update the two tests to pass the features object directly to
renderComponent (not wrapped in wrapperProps). Specifically, change the calls
that currently pass { wrapperProps: { features: {
'metadata.confidenceScore.enabled': true/false } } } to pass {
'metadata.confidenceScore.enabled': true } and {
'metadata.confidenceScore.enabled': false } respectively so
useFeatureEnabled('metadata.confidenceScore.enabled') receives the correct flag.
🧹 Nitpick comments (1)
src/elements/content-sidebar/__tests__/MetadataInstanceEditor.test.tsx (1)
166-172: Test is a basic smoke test — consider asserting the prop is forwarded.This test only verifies the component renders without crashing when
isConfidenceScoreReviewEnabledistrue, but doesn't assert any behavioral difference. SinceMetadataInstanceEditoris a pass-through wrapper, you could verify the prop reachesMetadataInstanceForm(e.g., via a snapshot or by checking a rendered artifact that depends on this flag). Low priority given this is a thin wrapper.
1cb51e4 to
a38bcc3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@package.json`:
- Line 138: Update the peerDependencies entry for `@box/metadata-editor` in
package.json to ^1.32.0 so it matches the devDependencies bump and ensures the
new isConfidenceScoreReviewEnabled prop (and related support in
MetadataInstanceForm / MetadataInstanceList) is available to consumers; locate
the existing peerDependencies block, replace the ^1.18.0 requirement for
`@box/metadata-editor` with ^1.32.0, then run install/tests to validate no other
dependency constraints break.
🧹 Nitpick comments (1)
src/elements/content-sidebar/__tests__/MetadataInstanceEditor.test.tsx (1)
166-172: Test doesn't assert anything specific toisConfidenceScoreReviewEnabled.This test is functionally identical to the first test (Lines 90–95) — it only checks that the template header renders. It doesn't verify that
isConfidenceScoreReviewEnabledis forwarded toMetadataInstanceFormor that it produces any observable difference in the rendered output. Consider asserting on a confidence-score-specific UI element or, at minimum, verifying the prop is passed through (e.g., via a spy onMetadataInstanceForm).
a38bcc3 to
484837e
Compare
Summary by CodeRabbit