New Y-Boundaries for unified sheath code#3308
Merged
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Makes it easier to reuse for other code
Mimicks the parallel case, to write FCI independent code
The boundary region does not match what is done for the parallel case, thus porting it to a iterator does not work.
hasBndryUpperY / hasBndryLowerY does not work for FCI and thus the request does not make sense / can be configured to throw. Thus it should not be checked if it is not needed.
BoundaryRegionIter has been delted
This allows to extend the boundary code to place the boundary further away from the boundary.
This is more general and takes the offset() into account, and thus works for cases where the boundary is between the first and second guard cell
Previously only the first boundary point was set
Taken from hermes-3, adopted for higher order
This allows to write code for FCI and non-FCI using templates.
Directly iterate over the points
| if (!args.empty()) { | ||
| try { | ||
| real_value = stringToReal(args.front()); | ||
| return new T(region, real_value); |
Contributor
There was a problem hiding this comment.
warning: returning a newly created resource of type 'BoundaryOpPar *' or 'gsl::owner<>' from a function whose return type is not 'gsl::owner<>' [cppcoreguidelines-owning-memory]
return new T(region, real_value);
^
| [[maybe_unused]] const int y_global_offset = | ||
| localmesh->getYProcIndex() * (localmesh->yend - localmesh->ystart + 1); | ||
| #if BOUT_HAS_PETSC | ||
| BOUT_FOR_SERIAL(i, getRegion(region)) { |
Contributor
There was a problem hiding this comment.
warning: no header providing "BOUT_FOR_SERIAL" is directly included [misc-include-cleaner]
BOUT_FOR_SERIAL(i, getRegion(region)) {
^
bendudson
added a commit
to boutproject/hermes-3
that referenced
this pull request
Jun 13, 2026
This function changed behavior in BOUT++ PR 3308 (boutproject/BOUT-dev#3308 , New Y-Boundaries for unified sheath code).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to implement unified BCs for yup/ydown as well as FCI / FA.
Taking into acount things like whether the boundary is next to the domain, or between the parallel slices.