Utility for setting up coordinates for a tokamak system#3046
Open
tomc271 wants to merge 99 commits intorefactor-coordinatesfrom
Open
Utility for setting up coordinates for a tokamak system#3046tomc271 wants to merge 99 commits intorefactor-coordinatesfrom
tomc271 wants to merge 99 commits intorefactor-coordinatesfrom
Conversation
…txy) to new file examples/common.hxx
elm-pb laplacexy/laplace_perp gyro-gem example (using zero for I parameter) alfven-wave example (using sinty for I parameter)
(rather than passing one to it for it to modify).
…esFactory constructor.
as `DataFileFacade.addOnce` method does not take const arguments.
because the function is marked const.
but need to copy value to a non-const variable to pass to `DataFileFacade.addOnce` method.
and its methods free functions.
…n't return anything
since TokamakCoordinates function now doesn't return Coordinates.
tomc271
force-pushed
the
dry-up-examples
branch
2 times, most recently
from
6a3c85a to
d08ecf9
Compare
ZedThree
reviewed
Jan 29, 2025
ZedThree
reviewed
Jan 29, 2025
tomc271
changed the title
dschwoerer
requested changes
Jan 31, 2025
Contributor
dschwoerer
left a comment
dschwoerer
left a comment
There was a problem hiding this comment.
Looks good, but can probably be further polished.
tomc271
force-pushed
the
dry-up-examples
branch
from
d08ecf9 to
0537766
Compare
ZedThree
reviewed
Feb 19, 2025
ZedThree
requested changes
Feb 19, 2025
tomc271
force-pushed
the
dry-up-examples
branch
from
0537766 to
e4a6b8d
Compare
ZedThree
reviewed
Feb 21, 2025
(Rename 'ShearFactor' back to 'I')
…ptional) integer parameter rather than a boolean Suggested on PR.
…oordinates()->dx()
tomc271
force-pushed
the
dry-up-examples
branch
from
e4a6b8d to
6b4ddcc
Compare
tomc271
force-pushed
the
dry-up-examples
branch
from
4517da9 to
10c1abe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted duplicated code for creating a Coordinates object for a tokamak system to a new file.