Skip to content

Add unit test for LaplaceXZPetsc#2359

Draft
dschwoerer wants to merge 7 commits intonextfrom
laplacexz-next
Draft

Add unit test for LaplaceXZPetsc#2359
dschwoerer wants to merge 7 commits intonextfrom
laplacexz-next

Conversation

@dschwoerer
Copy link
Copy Markdown
Contributor

No description provided.

@ZedThree
Copy link
Copy Markdown
Member

ZedThree commented Jul 1, 2021

See #2207 for some discussion

@ZedThree ZedThree changed the title LaplaceXZ is buggy Add unit test for LaplaceXZPetsc Jul 1, 2021
@ZedThree ZedThree mentioned this pull request Jul 1, 2021
11 tasks
@ZedThree
Copy link
Copy Markdown
Member

ZedThree commented Jul 7, 2021

Possible directions for investigation:

  • convergence checks for the round-trip test here: if the issue is one of mismatched discretisations, the error should decrease as we increase the resolution
  • analytic tests: this could be done in both uniform and spatially-dependent metric tensors by solving the forward operator with something like sympy or mathematica -- this would give us analytic tests for both forward and inverse operators

@github-actions
Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

#include <bout/field_factory.hxx>
#include <bout/invert/laplacexz.hxx>

using bout::globals::mesh;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: no header providing "bout::globals::mesh" is directly included [misc-include-cleaner]

tests/integrated/test-laplacexz/test-laplacexz.cxx:10:

- #include <bout/bout.hxx>
+ #include "bout/globals.hxx"
+ #include <bout/bout.hxx>

#include <bout/field_factory.hxx>
#include <bout/invert/laplacexz.hxx>

using bout::globals::mesh;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: using decl 'mesh' is unused [misc-unused-using-decls]

using bout::globals::mesh;
                     ^
Additional context

tests/integrated/test-laplacexz/test-laplacexz.cxx:16: remove the using

using bout::globals::mesh;
                     ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants