[3D metric] Use Bxy.ydown() for div_a_laplace_perp#2312
Merged
ZedThree merged 1 commit intocoord3d_merged2from May 19, 2021
Merged
[3D metric] Use Bxy.ydown() for div_a_laplace_perp#2312ZedThree merged 1 commit intocoord3d_merged2from
ZedThree merged 1 commit intocoord3d_merged2from
Conversation
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
ZedThree
approved these changes
May 12, 2021
Member
|
Do you know if this solves the issues in #2207? |
Contributor
Author
I knew you would ask. I don't think so, unfortunately. |
Member
|
Failing test is readthedocs -- there's another PR which will merge next into the 3D metrics branch which should fix it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a slight bug where only the yup field and metrics were used.