Add PKHeX installer (Silver)#477
Draft
Azevedoc wants to merge 2 commits intobottlesdevs:mainfrom
Draft
Conversation
PKHeX is a Pokémon core series save editor running on .NET Desktop Runtime 10. Includes a DPI awareness workaround for Wine compatibility and a review documenting current test results.
Move install directory from Program Files/PKHeX to PKHeX to avoid path quoting issues with Bottles. Document the required env var workaround (DOTNET_SYSTEM_GLOBALIZATION_USENLS=true) for .NET ICU culture enumeration bug when running under Wine.
Member
|
Hi, thanks for contributing. I think there are a lot of issues with it though:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add PKHeX, a Pokémon core series save editor. Requires .NET Desktop Runtime 10 (installed automatically) and a DPI awareness registry workaround to prevent crashes on file dialogs under Wine.
Workarounds included:
DPIUNAWAREAppCompatFlags registry key to avoidSetThreadDpiAwarenessContextcrash in .NET 10 WinFormsKnown cosmetic issues:
Note: During testing, the installer's "Proceed" button for local resources was invisible on a system with libadwaita 1.9+. This seems to be an upstream Bottles bug —
btn_proceedindialog-installer.blpis a bareGtkButtonchild ofAdwPreferencesPage, which may silently drop non-group children in newer libadwaita. Details documented inReviews/bottles-libadwaita-1.9-proceed-button.md.Type of change
Was This Tested Using a Local Repository?