Open
Conversation
to satisfy the gRPC logics
| // Requests | ||
| message CreateBottleRequest { | ||
| string name = 1; | ||
| string type = 2; // e.g., "Gaming", "Software", "Custom" |
Contributor
There was a problem hiding this comment.
type should be an enum
enum BottleType {
Gaming = 1;
Software = 2;
Custom = 3;
}
Comment on lines
+85
to
+94
| message BottleConfig { | ||
| string runner = 1; | ||
| string dxvk_version = 2; | ||
| string vkd3d_version = 3; | ||
| string latencyflex_version = 4; // Optional | ||
| bool dxvk_nvapi = 5; | ||
| bool esync = 6; | ||
| bool fsync = 7; | ||
| // Add other relevant settings | ||
| } |
Contributor
There was a problem hiding this comment.
BottleConfig should be sent as a map probably. Not as individual fields
| // System | ||
| message ShutdownRequest {} | ||
|
|
||
| message WinebootRequest { |
|
|
||
| message MessageResponse { | ||
| bool success = 1; | ||
| string error = 2; // Optional error detail |
Contributor
There was a problem hiding this comment.
if error is optional make it
optional string error = 2;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not a complete feature but the basis to complete the gRPC structure.