-
Notifications
You must be signed in to change notification settings - Fork 0
do not include tests or bin in git archives #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Robert Landers <landers.robert@gmail.com>
WalkthroughA Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2 #153 +/- ##
============================================
+ Coverage 46.25% 46.28% +0.02%
Complexity 1250 1250
============================================
Files 99 99
Lines 3565 3565
============================================
+ Hits 1649 1650 +1
+ Misses 1916 1915 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Robert Landers <landers.robert@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/build-cli.yaml (1)
98-102: Verify Composer availability & add non-interactive flagsRemoving the
dphpwrapper presumes theruntime-testsimage already ships acomposerbinary on$PATH. If that assumption is wrong the job will fail at runtime.
While touching this line, it is also worth adding the standard non-interactive flags to make the step deterministic and faster in CI:- composer install --ignore-platform-reqs + composer install --ignore-platform-reqs --no-interaction --no-progress --prefer-distPlease double-check the image and, if needed, install Composer or revert to
dphp composer …to guarantee the same PHP environment as the subsequentdphp execcommands.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/build-cli.yaml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build-docker
- GitHub Check: Unit Tests - PHP
Signed-off-by: Robert Landers <landers.robert@gmail.com>
Performance Metrics
|
Summary by CodeRabbit