fix time class

[withinboredom]

Summary by CodeRabbit

• Refactor

  • Updated type hints for constructor parameters to use nullable shorthand for improved code clarity.
  • Simplified import statements for the Time class across multiple files.

• Chores

  • Updated PHP include path configuration to add new vendor directories.

[coderabbitai]

Walkthrough

This update modifies import statements for the Time class in two PHP source files, adjusting namespace usage and type hints. Additionally, it updates the PHP include path configuration in the .idea/php.xml file by appending three new vendor directories. No logic, control flow, or error handling changes are present.

Changes

Cohort / File(s)	Change Summary
IDE Configuration Update .idea/php.xml	Added three vendor directories (symfony/polyfill-php80, bottledcode/php-rql, squizlabs/php_codesniffer) to the PHP include path configuration.
Namespace and Type Hint Adjustments src/RetryOptions.php, src/State/Attributes/TimeToLive.php	Updated import statements for the Time class to use a different namespace; in RetryOptions.php, also updated constructor parameter type hints to use nullable shorthand.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A bunny hops through code so bright,
Tweaking imports left and right.
Paths are set, the vendors grow,
Type hints clearer as they flow.
With every hop, the code feels new—
A rabbit’s work, concise and true! 🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f8ddf68 and 3b8c6dd.

📒 Files selected for processing (3)

• .idea/php.xml (1 hunks)
• src/RetryOptions.php (3 hunks)
• src/State/Attributes/TimeToLive.php (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: build-docker
• GitHub Check: Unit Tests - PHP

🔇 Additional comments (4)

.idea/php.xml (1)

150-152: LGTM!

The addition of these vendor paths to the IDE configuration is standard practice and will help PhpStorm recognize the new dependencies correctly.

src/State/Attributes/TimeToLive.php (1)

28-28: Namespace imports for Time are consistent

All instances of the old import Withinboredom\Time\Time have been removed and replaced with Withinboredom\Time;. Verified across:

• src/RetryOptions.php
• src/State/Attributes/TimeToLive.php
• src/Events/EventQueue.php

No remaining references to the old namespace. You can safely merge.

src/RetryOptions.php (2)

27-27: LGTM!

The import simplification is consistent with the changes in TimeToLive.php and aligns with the PR objective.

---

36-36: Good improvement using nullable shorthand syntax.

The change from Time|null to ?Time uses the preferred nullable shorthand syntax while maintaining the same functionality.

Also applies to: 38-38

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/time

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.35%. Comparing base (f8ddf68) to head (3b8c6dd).
⚠️ Report is 1 commits behind head on v2.

Additional details and impacted files

@@             Coverage Diff              @@
##                 v2     #150      +/-   ##
============================================
+ Coverage     46.29%   46.35%   +0.05%     
  Complexity     1248     1248              
============================================
  Files            99       99              
  Lines          3562     3562              
============================================
+ Hits           1649     1651       +2     
+ Misses         1913     1911       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

Performance Metrics

test	time (s)	memory usage
perf	15.93	102
Fan out/in	60.06	8