Skip to content

chore: Add CODEOWNERS file to better reflect ownership#681

Open
SebastienPoitras wants to merge 2 commits intomasterfrom
spoit/update-codeowners-file
Open

chore: Add CODEOWNERS file to better reflect ownership#681
SebastienPoitras wants to merge 2 commits intomasterfrom
spoit/update-codeowners-file

Conversation

@SebastienPoitras
Copy link
Copy Markdown

@SebastienPoitras SebastienPoitras commented Apr 9, 2026

A ruleset will also be added to enforce a minimum of one review by engineering, ensuring coverage of all files in the repository.

@SebastienPoitras SebastienPoitras marked this pull request as ready for review April 13, 2026 15:04
@SebastienPoitras SebastienPoitras requested a review from a team April 13, 2026 15:04
@greptile-apps
Copy link
Copy Markdown

greptile-apps bot commented Apr 13, 2026

Greptile Summary

This PR refines CODEOWNERS by assigning per-package owners (adding pingrip and moving tunnel to @botpress/kraken) and dropping the shared @botpress/leads co-ownership. It also removes the * @botpress/engineering catch-all that previously ensured every file had at least one required reviewer.

  • The seven packages not listed in the file — expresso, genenv, mcp-gen, retry, signature-verification, thicktoken, zui — plus root-level files have no code owner after this change, until the companion ruleset described in the PR description is also merged.

Confidence Score: 4/5

Safe to merge only if the companion ruleset enforcing engineering review is merged simultaneously; merging this file alone leaves several packages without any required reviewer.

The removal of the * @botpress/engineering catch-all is a present, actionable gap — seven packages plus root files will have no designated owner between this change and the promised (but not yet merged) ruleset. This is a P1 finding that should be addressed before or alongside merging.

CODEOWNERS — the missing catch-all and unowned packages need to be resolved.

Important Files Changed

Filename Overview
CODEOWNERS Removes the * @botpress/engineering catch-all and @botpress/leads co-owners; adds pingrip/tunnel to @botpress/kraken, but leaves 7 packages (expresso, genenv, mcp-gen, retry, signature-verification, thicktoken, zui) and root files without any designated owner.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    PR[Pull Request / File Change]
    PR --> CO{CODEOWNERS match?}

    CO -->|Explicit match| PKG[Package-specific owner notified]
    CO -->|No match - BEFORE this PR| ENG[botpress/engineering notified via wildcard *]
    CO -->|No match - AFTER this PR| NONE[❌ No owner - no required review]

    PKG --> E1[entities → @franklevasseur]
    PKG --> E2[depsynky / es-node / jex / log4bot / opapi / readiness / verel / yargs-extra / slackdown → @botpress/squid]
    PKG --> E3[pingrip / tunnel → @botpress/kraken]
    PKG --> E4[promex / trail → @michaelmass]
    PKG --> E5[ptb-schema → @franklevasseur]

    NONE --> GAP["Unowned: expresso, genenv, mcp-gen,\nretry, signature-verification, thicktoken, zui\n+ root files"]

    style NONE fill:#f55,color:#fff
    style GAP fill:#faa
Loading

Reviews (1): Last reviewed commit: "chore: Add CODEOWNERS file to better ref..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant