Skip to content

Revert wrong fix, apply correct fix for #9513#9543

Merged
ThomasWaldmann merged 2 commits intoborgbackup:masterfrom
ThomasWaldmann:revert-pr-9535
Mar 25, 2026
Merged

Revert wrong fix, apply correct fix for #9513#9543
ThomasWaldmann merged 2 commits intoborgbackup:masterfrom
ThomasWaldmann:revert-pr-9535

Conversation

@ThomasWaldmann
Copy link
Member

@ThomasWaldmann ThomasWaldmann commented Mar 25, 2026

This reverts commit 9d5687d. The env vars added were already set in the job's env section. Also, it did not fix #9513.

To fix #9513, the MSYS2 env vars needed to be added to the canary CI workflow file.

@ThomasWaldmann ThomasWaldmann changed the title Revert "ci: disable MSYS2 path conversion in windows tests, fixes #9513" Revert wrong fix, apply correct fix for #9513 Mar 25, 2026
@codecov
Copy link

codecov bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.40%. Comparing base (9d5687d) to head (e9a7349).
⚠️ Report is 6 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9543   +/-   ##
=======================================
  Coverage   83.39%   83.40%           
=======================================
  Files          87       87           
  Lines       15469    15469           
  Branches     2321     2321           
=======================================
+ Hits        12901    12902    +1     
  Misses       1818     1818           
+ Partials      750      749    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ThomasWaldmann ThomasWaldmann merged commit 857db05 into borgbackup:master Mar 25, 2026
15 of 16 checks passed
@ThomasWaldmann ThomasWaldmann deleted the revert-pr-9535 branch March 25, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: tests failing on windows

1 participant