Skip to content

Use mtime-based files cache default on Windows #9530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hiijoshi wants to merge 1 commit into from
Closed

Use mtime-based files cache default on Windows #9530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/borg/archiver/create_cmd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -919,8 +919,10 @@ def build_parser_create(self, subparsers, common_parser, mid_common_parser):
dest="files_cache_mode",
action=Highlander,
type=FilesCacheMode,
default=FILES_CACHE_MODE_UI_DEFAULT,
help="operate files cache in MODE. default: %s" % FILES_CACHE_MODE_UI_DEFAULT,
default=FILES_CACHE_MODE_UI_DEFAULT_WIN32 if is_win32 else FILES_CACHE_MODE_UI_DEFAULT,
help=("operate files cache in MODE. default: %s"
% (FILES_CACHE_MODE_UI_DEFAULT_WIN32 if is_win32 else FILES_CACHE_MODE_UI_DEFAULT)
),
)
fs_group.add_argument(
"--files-changed",
Expand Down
1 change: 1 addition & 0 deletions src/borg/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@

# operating mode of the files cache (for fast skipping of unchanged files)
FILES_CACHE_MODE_UI_DEFAULT = "ctime,size,inode" # default for "borg create" command (CLI UI)
FILES_CACHE_MODE_UI_DEFAULT_WIN32 = "mtime,size,inode" # default for "borg create" on win32
FILES_CACHE_MODE_DISABLED = "d" # most borg commands do not use the files cache at all (disable)

# account for clocks being slightly out-of-sync, timestamps granularity.
Expand Down
Loading