Added info output to prune command#9271
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.4-maint #9271 +/- ##
=============================================
+ Coverage 80.57% 80.61% +0.03%
=============================================
Files 38 38
Lines 11256 11260 +4
Branches 1771 1771
=============================================
+ Hits 9070 9077 +7
+ Misses 1616 1615 -1
+ Partials 570 568 -2 ☔ View full report in Codecov by Sentry. |
ThomasWaldmann
left a comment
There was a problem hiding this comment.
Thanks for the PR, some feedback...
|
I updated the code according to your suggestions. The stats are now displayed via logger info before the deletion loop. |
|
BTW, did you practically test it how the output looks like when mixing -v / --list / --stats / --progress in different combinations? --list and --progress are expected to not look good when used together, but the other combinations should look ok. |
|
I have updated the code according to your feedback: Replaced list comprehensions with set operations (len(set(...) - set(...))) for better performance. Restored the original if args.stats: block at the end that I had accidentally removed. Verified that the output looks correct when combining -v with --list, --stats, and --progress. |
|
Removed the redundant logger line |
|
Thanks @Konmous04! |
Fixes #9262.
-v / --info displays archive counts (total, kept, pruned).