fuse: add ACL support (Linux)#8843
Draft
ThomasWaldmann wants to merge 3 commits intoborgbackup:masterfrom
Draft
Conversation
ThomasWaldmann
commented
May 17, 2025
Comment on lines
+341
to
+347
| size = acl_size(acl) | ||
| if size < 0: | ||
| raise OSError(errno.errno, "Failed to get ACL size") | ||
| # Create a bytes object from the ACL data structure: | ||
| return PyBytes_FromStringAndSize(<char *> acl, size) |
Member
Author
There was a problem hiding this comment.
This is a bit dirty, but there is no official API call for this.
ThomasWaldmann
force-pushed
the
fuse-acls-linux
branch
2 times, most recently
from
49340f2 to
c60aaf0
Compare
ThomasWaldmann
force-pushed
the
fuse-acls-linux
branch
from
c60aaf0 to
e79c02b
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8843 +/- ##
=========================================
Coverage ? 82.05%
=========================================
Files ? 77
Lines ? 13515
Branches ? 2004
=========================================
Hits ? 11090
Misses ? 1759
Partials ? 666 ☔ View full report in Codecov by Sentry. |
ThomasWaldmann
force-pushed
the
fuse-acls-linux
branch
3 times, most recently
from
8a36d8d to
cd576c2
Compare
ThomasWaldmann
force-pushed
the
fuse-acls-linux
branch
from
cd576c2 to
0bda4f5
Compare
ThomasWaldmann
commented
Jan 4, 2026
| try: | ||
| return item.get("xattrs", {})[name] or b"" | ||
| if name == b"system.posix_acl_access": | ||
| return get_binary_acl(item, "acl_access", self.numeric_ids) |
Member
Author
There was a problem hiding this comment.
if the get_binary_acl does not work for some reason, another approach could be:
- borg create: archive ALL xattrs (including the ones used for ACLs)
- borg extract: skip extracting the xattrs for acls, because acl functions will be used to create these
- borg mount: just list/get all xattrs as archived now in the item and check if ACLs work then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Junie (AI) experiment + some fixes the AI was not clever enough for.
But, tests fail - anyone wants to review this?