Improve backup.marker error message for rsync_tmbackup importer#82
Open
hiijoshi wants to merge 5 commits intoborgbackup:masterfrom
Open
Improve backup.marker error message for rsync_tmbackup importer#82hiijoshi wants to merge 5 commits intoborgbackup:masterfrom
hiijoshi wants to merge 5 commits intoborgbackup:masterfrom
Conversation
ThomasWaldmann
requested changes
Mar 21, 2026
Member
ThomasWaldmann
left a comment
There was a problem hiding this comment.
good change. but maybe do PRs a bit differently in general as there is a huge overlap in the way you do it now:
if you do 2 independent changes (like working on the docs vs. improving the code), do 2 PRs, one only with the docs changes, one only with the code changes.
if a change depends on a previous PR, you can include the commits of the previous PR in the next PR (and maybe add a PR comment like "this PR depends on (previous PR)".
Author
|
Thanks for the feedback! I’ve cleaned up this PR to include only the error message improvement for the rsync_tmbackup importer. The other changes (tests and docs) are kept in their respective separate PRs. Please let me know if this looks better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improved the error message shown when backup.marker is missing in the rsync_tmbackup importer.
Changes
Reason
This makes the error easier to understand and helps users quickly identify which directory is missing the required marker file.