Add test for rsync_tmbackup importer#80
Open
hiijoshi wants to merge 3 commits intoborgbackup:masterfrom
Open
Conversation
|
|
||
| assert len(archives) >= 1 | ||
| assert any("backup1" in a or "backup2" in a for a in archives) | ||
| def test_rsync_tmbackup_import(tmpdir, monkeypatch): |
Member
There was a problem hiding this comment.
usually always have 2 empty lines between toplevel functions. but here, this also belongs into a different test module test_tmbackup.
| ).decode() | ||
| archives = output.splitlines() | ||
|
|
||
| assert len(archives) >= 1 No newline at end of file |
Member
There was a problem hiding this comment.
that's a rather weak assertion. :-)
| regex = re.compile(r"(?P<snapshot_date>.+)") | ||
|
|
||
| if not Path("backup.marker").exists(): | ||
| if not (root / "backup.marker").exists(): |
Member
There was a problem hiding this comment.
that looks like a bug fix?
Author
|
Thanks for the review! I’ve updated the PR by:
All tests are passing locally. Please let me know if anything else should be improved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added a test for the rsync_tmbackup importer.
Changes
Reason
This extends importer test coverage using the same integration-style approach already used in the existing test suite.