Skip to content

ci#442

Open
Luizcs2 wants to merge 24 commits intobootdotdev:mainfrom
Luizcs2:main
Open

ci#442
Luizcs2 wants to merge 24 commits intobootdotdev:mainfrom
Luizcs2:main

Conversation

@Luizcs2
Copy link

@Luizcs2 Luizcs2 commented Mar 6, 2026

No description provided.

Copilot AI review requested due to automatic review settings March 6, 2026 09:06
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an initial GitHub Actions CI workflow and a small README footer note, aiming to introduce automated checks on pull requests.

Changes:

  • Added a new GitHub Actions workflow at .github/workflows/ci.yaml.
  • Appended a short attribution line to README.md.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
README.md Adds an extra line at the end of the README (minor documentation change).
.github/workflows/ci.yaml Introduces a PR-triggered CI workflow (currently malformed and intentionally failing).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment on lines +1 to +22
name :ci

on:
pull_request:
branches:[main]

jobs:
tests:
name:Tests
runs-on: ubuntu-latest

steps:
-name:check out code
uses: actions/checkout@v4

-name: Set up Node
uses: actions/setup-node@v4
with :
node-version: 22

-name: Force Failure
run: (exit 1)
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow YAML has invalid/incorrect GitHub Actions syntax at the top level (e.g., name :ci and branches:[main]). GitHub expects keys like name: and branches: [main] (or multiline list); as written this is likely to fail YAML parsing or not match the intended branches filter.

Suggested change
name :ci
on:
pull_request:
branches:[main]
jobs:
tests:
name:Tests
runs-on: ubuntu-latest
steps:
-name:check out code
uses: actions/checkout@v4
-name: Set up Node
uses: actions/setup-node@v4
with :
node-version: 22
-name: Force Failure
run: (exit 1)
name: ci
on:
pull_request:
branches: [main]
jobs:
tests:
name: Tests
runs-on: ubuntu-latest
steps:
- name: Check out code
uses: actions/checkout@v4
- name: Set up Node
uses: actions/setup-node@v4
with:
node-version: 22
- name: Force Failure
run: exit 1

Copilot uses AI. Check for mistakes.
Comment on lines +13 to +22
-name:check out code
uses: actions/checkout@v4

-name: Set up Node
uses: actions/setup-node@v4
with :
node-version: 22

-name: Force Failure
run: (exit 1)
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The steps section is not valid: list items must be written as - name: ... and indented under steps:. Entries like -name:check out code / with : will not be interpreted correctly by GitHub Actions.

Suggested change
-name:check out code
uses: actions/checkout@v4
-name: Set up Node
uses: actions/setup-node@v4
with :
node-version: 22
-name: Force Failure
run: (exit 1)
- name: check out code
uses: actions/checkout@v4
- name: Set up Node
uses: actions/setup-node@v4
with:
node-version: 22
- name: Force Failure
run: (exit 1)

Copilot uses AI. Check for mistakes.
Comment on lines +21 to +22
-name: Force Failure
run: (exit 1)
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI job currently contains a Force Failure step that exits with status 1, which will make every PR check fail. Remove this step and replace it with the actual CI commands (e.g., npm ci and npm run build, and/or tests if present).

Suggested change
-name: Force Failure
run: (exit 1)
-name: Install dependencies
run: npm ci
-name: Run tests
run: npm test

Copilot uses AI. Check for mistakes.

You do _not_ need to set up a database or any interactivity on the webpage yet. Instructions for that will come later in the course!

luiz's version of Boot.dev's Notely app.
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added line reads like a sentence but starts with a lowercase proper name (luiz's). Consider capitalizing it (e.g., Luiz's) and/or removing this personal note if the README is intended to stay focused on project usage/documentation.

Suggested change
luiz's version of Boot.dev's Notely app.
Luiz's version of Boot.dev's Notely app.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants