Conversation
added name in read me
There was a problem hiding this comment.
Pull request overview
Adds an initial GitHub Actions CI workflow and a small README footer note, aiming to introduce automated checks on pull requests.
Changes:
- Added a new GitHub Actions workflow at
.github/workflows/ci.yaml. - Appended a short attribution line to
README.md.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| README.md | Adds an extra line at the end of the README (minor documentation change). |
| .github/workflows/ci.yaml | Introduces a PR-triggered CI workflow (currently malformed and intentionally failing). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
.github/workflows/ci.yaml
Outdated
| name :ci | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches:[main] | ||
|
|
||
| jobs: | ||
| tests: | ||
| name:Tests | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| -name:check out code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| -name: Set up Node | ||
| uses: actions/setup-node@v4 | ||
| with : | ||
| node-version: 22 | ||
|
|
||
| -name: Force Failure | ||
| run: (exit 1) |
There was a problem hiding this comment.
The workflow YAML has invalid/incorrect GitHub Actions syntax at the top level (e.g., name :ci and branches:[main]). GitHub expects keys like name: and branches: [main] (or multiline list); as written this is likely to fail YAML parsing or not match the intended branches filter.
| name :ci | |
| on: | |
| pull_request: | |
| branches:[main] | |
| jobs: | |
| tests: | |
| name:Tests | |
| runs-on: ubuntu-latest | |
| steps: | |
| -name:check out code | |
| uses: actions/checkout@v4 | |
| -name: Set up Node | |
| uses: actions/setup-node@v4 | |
| with : | |
| node-version: 22 | |
| -name: Force Failure | |
| run: (exit 1) | |
| name: ci | |
| on: | |
| pull_request: | |
| branches: [main] | |
| jobs: | |
| tests: | |
| name: Tests | |
| runs-on: ubuntu-latest | |
| steps: | |
| - name: Check out code | |
| uses: actions/checkout@v4 | |
| - name: Set up Node | |
| uses: actions/setup-node@v4 | |
| with: | |
| node-version: 22 | |
| - name: Force Failure | |
| run: exit 1 |
.github/workflows/ci.yaml
Outdated
| -name:check out code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| -name: Set up Node | ||
| uses: actions/setup-node@v4 | ||
| with : | ||
| node-version: 22 | ||
|
|
||
| -name: Force Failure | ||
| run: (exit 1) |
There was a problem hiding this comment.
The steps section is not valid: list items must be written as - name: ... and indented under steps:. Entries like -name:check out code / with : will not be interpreted correctly by GitHub Actions.
| -name:check out code | |
| uses: actions/checkout@v4 | |
| -name: Set up Node | |
| uses: actions/setup-node@v4 | |
| with : | |
| node-version: 22 | |
| -name: Force Failure | |
| run: (exit 1) | |
| - name: check out code | |
| uses: actions/checkout@v4 | |
| - name: Set up Node | |
| uses: actions/setup-node@v4 | |
| with: | |
| node-version: 22 | |
| - name: Force Failure | |
| run: (exit 1) |
.github/workflows/ci.yaml
Outdated
| -name: Force Failure | ||
| run: (exit 1) |
There was a problem hiding this comment.
The CI job currently contains a Force Failure step that exits with status 1, which will make every PR check fail. Remove this step and replace it with the actual CI commands (e.g., npm ci and npm run build, and/or tests if present).
| -name: Force Failure | |
| run: (exit 1) | |
| -name: Install dependencies | |
| run: npm ci | |
| -name: Run tests | |
| run: npm test |
|
|
||
| You do _not_ need to set up a database or any interactivity on the webpage yet. Instructions for that will come later in the course! | ||
|
|
||
| luiz's version of Boot.dev's Notely app. |
There was a problem hiding this comment.
The added line reads like a sentence but starts with a lowercase proper name (luiz's). Consider capitalizing it (e.g., Luiz's) and/or removing this personal note if the README is intended to stay focused on project usage/documentation.
| luiz's version of Boot.dev's Notely app. | |
| Luiz's version of Boot.dev's Notely app. |
Addtests
Addtests
ch2:L2: changed name to tests
No description provided.