-
Notifications
You must be signed in to change notification settings - Fork 3
ci: Bump bcvk #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Bump bcvk #57
Conversation
And yes we need this in closer to one place. Signed-off-by: Colin Walters <walters@verbum.org>
Summary of ChangesHello @cgwalters, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on synchronizing the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the bcvk version to 0.9.0 across three files, making them consistent. As you've noted in the pull request description, having the version defined in multiple places is not ideal for maintainability. It would be beneficial to consolidate this into a single source of truth in a follow-up. My review includes a specific suggestion for the GitHub Action file to make the version manageable by Renovate, which would be a good step towards better dependency management for this repository.
| run: | | ||
| set -xeuo pipefail | ||
| export BCVK_VERSION=0.8.0 | ||
| export BCVK_VERSION=0.9.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This hardcoded version of bcvk is not tracked by Renovate, unlike the versions in the Containerfiles. This can lead to this version becoming stale and inconsistent with other parts of the repository. To improve maintainability, consider managing this version in a way that Renovate can automatically update it. One approach is to define the version as an input to this composite action and configure Renovate (likely via a custom regex manager) to update its default value. This would align with the goal of centralizing version management mentioned in the PR description.
And yes we need this in closer to one place.