devenv: Add opencode and rsync, drop duplicate code #56
Conversation
I had been trying hard to use goose because I like Rust and some of the core code is good, but opencode seems to be nicer and well maintained. Add infra to inject bits from npm and use it to install. rsync is needed for my dotfiles install and is generally useful. Signed-off-by: Colin Walters <walters@verbum.org>
These files are no longer used after forking the Containerfile into Containerfile.debian and Containerfile.c10s variants. The package lists have been split into packages-common.txt plus distro-specific files (packages-debian.txt, packages-c10s.txt, build-deps-debian.txt, build-deps-c10s.txt). Assisted-by: OpenCode (Claude Sonnet 4) Signed-off-by: Colin Walters <walters@verbum.org>
Summary of ChangesHello @cgwalters, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines and refactors the development environment setup by eliminating a monolithic Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the devenv setup to support multiple distributions (Debian and CentOS Stream 10) by splitting the monolithic Containerfile into Containerfile.debian and Containerfile.c10s. This also involves splitting package lists into common and distribution-specific files. As part of this, opencode-ai and rsync are added as new dependencies. The changes are well-structured and improve maintainability. I've added a couple of minor suggestions to improve the robustness of package installation scripts.
| dnf clean all | ||
| EORUN | ||
| COPY npm.txt /run/src | ||
| RUN grep -vEe '^#' npm.txt | /bin/time -f '%E %C' xargs npm i -g |
There was a problem hiding this comment.
For robustness, it's a good practice to use the --no-run-if-empty (or -r) flag with xargs. This prevents xargs from running npm i -g if npm.txt is empty or contains only comments, which avoids an unnecessary command execution.
RUN grep -vEe '^#' npm.txt | /bin/time -f '%E %C' xargs -r npm i -g
| apt clean && rm -rf /var/lib/apt/lists/* | ||
| EORUN | ||
| COPY npm.txt /run/src | ||
| RUN grep -vEe '^#' npm.txt | /bin/time -f '%E %C' xargs npm i -g |
There was a problem hiding this comment.
For robustness, it's a good practice to use the --no-run-if-empty (or -r) flag with xargs. This prevents xargs from running npm i -g if npm.txt is empty or contains only comments, which avoids an unnecessary command execution.
RUN grep -vEe '^#' npm.txt | /bin/time -f '%E %C' xargs -r npm i -g
3 participants
No description provided.