-
Notifications
You must be signed in to change notification settings - Fork 3
Bump to bcvk 0.7.0 #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Colin Walters <walters@verbum.org>
Summary of ChangesHello @cgwalters, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the bcvk version to 0.7.0 in two places. The changes are correct and align the versions used in the GitHub Action and the development Containerfile. I've added a couple of suggestions to improve long-term maintainability by making the version management more consistent and automated.
| run: | | ||
| set -xeuo pipefail | ||
| export BCVK_VERSION=0.6.0 | ||
| export BCVK_VERSION=0.7.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This version is hardcoded. To improve maintainability and ensure it's updated automatically in the future, it would be beneficial to make it manageable by Renovate. You could add a # renovate: ... comment on the line above this one, similar to how it's done in devenv/Containerfile.debian. This would require a corresponding regex manager configuration in renovate-shared-config.json to parse shell variable exports.
| ARG gooseversion=v1.11.1 | ||
| # renovate: datasource=github-releases depName=bootc-dev/bcvk | ||
| ARG bcvkversion=v0.5.3 | ||
| ARG bcvkversion=v0.7.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've noticed an inconsistency in how the bcvk version is specified. Here it is v0.7.0 (with a v prefix), while in common/.github/actions/bootc-ubuntu-setup/action.yml it is 0.7.0 (without a v prefix). While the surrounding code in each file correctly handles its format, using a consistent format (e.g., always with the v prefix) would improve clarity and reduce potential errors in the future. Since Renovate is configured for this file and uses the v prefix, it might be best to adopt this format in the action.yml as well (which would require a small change where the variable is used).
No description provided.