ci: Add bootc/ submodule for reverse dependency testing #119
Open
cgwalters wants to merge 2 commits intobootc-dev:mainfrom
Open
ci: Add bootc/ submodule for reverse dependency testing #119cgwalters wants to merge 2 commits intobootc-dev:mainfrom
cgwalters wants to merge 2 commits intobootc-dev:mainfrom
Conversation
Add a toplevel Justfile with common development targets that wrap cargo commands: - build/build-release: Build workspace - test: Run all tests - clippy: Run clippy lints - fmt/fmt-check: Format code - check: Run all checks (clippy + fmt + test) - clean: Clean build artifacts Assisted-by: OpenCode (Sonnet 4) Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
revdep-ci-bootc
branch
from
f289381 to
9fc6ed4
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces Justfiles to automate building and testing against bootc as a reverse dependency, enhancing CI and local development. A significant security concern was identified in bootc/Justfile related to command injection, where environment variables are directly interpolated into shell scripts. Beyond this, the clone target could be refactored for improved robustness and idempotency, and the use of sudo in the test target should be addressed for security and portability reasons.
cgwalters
force-pushed
the
revdep-ci-bootc
branch
from
9fc6ed4 to
0f7cc33
Compare
cgwalters
force-pushed
the
revdep-ci-bootc
branch
2 times, most recently
from
303c176 to
7256d91
Compare
jeckersb
reviewed
Jan 23, 2026
cgwalters
force-pushed
the
revdep-ci-bootc
branch
from
7256d91 to
504c9c2
Compare
Follows the general pattern in bootc of ensuring that GHA flows are delegating heavy lifting to targets easily executable locally via `just`. Add bootc/Justfile as a just submodule (invoked via just bootc/<target>) that handles cloning, patching, building, and testing bootc against the local containers-image-proxy-rs checkout. Assisted-by: OpenCode (Sonnet 4) Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
revdep-ci-bootc
branch
from
504c9c2 to
fbe8316
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows the general pattern in bootc of ensuring that GHA flows
are delegating heavy lifting to targets easily executable locally
via
just.Add bootc/Justfile as a just submodule (invoked via just bootc/)
that handles cloning, patching, building, and testing bootc against the
local containers-image-proxy-rs checkout.