test: ci/merge label with failing build — should still enter merge queue#63
test: ci/merge label with failing build — should still enter merge queue#63cgwalters wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds a text file to the test-results/ directory to document a CI test scenario. Feedback suggests moving this file to a more permanent directory like tests/ or ci/ to follow standard conventions and avoid accidental deletion, along with a suggestion for more formal wording.
| @@ -0,0 +1 @@ | |||
| This PR uses ci/merge label but has ci/fail-build. Key test: required-checks should still go green on the PR so it can enter the merge queue. | |||
There was a problem hiding this comment.
The directory 'test-results/' is conventionally used for ephemeral test output and reports, which are typically excluded from version control. Committing a persistent file here may be confusing or lead to accidental deletion by cleanup scripts. Consider moving this file to a directory intended for test sources or documentation, such as 'tests/' or 'ci/'. Additionally, the description could be more formal and use clearer terminology.
This PR uses the 'ci/merge' label and the 'ci/fail-build' file. The key test is to verify that 'required-checks' passes on the PR, allowing it to enter the merge queue.
64ecf0c to
34f2ee5
Compare
Has
ci/fail-buildso the tier-1buildjob will deliberately fail. Theci/mergelabel is applied so the full tier-2 suite runs too.Key test:
required-checksshould still turn green on the PR (becauserequired-checks-mergeis skipped onpull_requestevents), allowing this PR to enter the merge queue even with the failing heavy job.In the merge queue the jobs run fresh, so a flaky job gets a clean retry.