Skip to content

test: ci/merge label with failing build — should still enter merge queue#63

Open
cgwalters wants to merge 1 commit into
mainfrom
test/ci-merge-with-failing-build
Open

test: ci/merge label with failing build — should still enter merge queue#63
cgwalters wants to merge 1 commit into
mainfrom
test/ci-merge-with-failing-build

Conversation

@cgwalters
Copy link
Copy Markdown
Contributor

Has ci/fail-build so the tier-1 build job will deliberately fail. The ci/merge label is applied so the full tier-2 suite runs too.

Key test: required-checks should still turn green on the PR (because required-checks-merge is skipped on pull_request events), allowing this PR to enter the merge queue even with the failing heavy job.

In the merge queue the jobs run fresh, so a flaky job gets a clean retry.

@cgwalters cgwalters added the ci/merge Run full CI suite (all OSes) — equivalent to merge queue label May 19, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a text file to the test-results/ directory to document a CI test scenario. Feedback suggests moving this file to a more permanent directory like tests/ or ci/ to follow standard conventions and avoid accidental deletion, along with a suggestion for more formal wording.

@@ -0,0 +1 @@
This PR uses ci/merge label but has ci/fail-build. Key test: required-checks should still go green on the PR so it can enter the merge queue.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The directory 'test-results/' is conventionally used for ephemeral test output and reports, which are typically excluded from version control. Committing a persistent file here may be confusing or lead to accidental deletion by cleanup scripts. Consider moving this file to a directory intended for test sources or documentation, such as 'tests/' or 'ci/'. Additionally, the description could be more formal and use clearer terminology.

This PR uses the 'ci/merge' label and the 'ci/fail-build' file. The key test is to verify that 'required-checks' passes on the PR, allowing it to enter the merge queue.

@cgwalters cgwalters force-pushed the test/ci-merge-with-failing-build branch from 64ecf0c to 34f2ee5 Compare May 19, 2026 16:03
@cgwalters cgwalters added this pull request to the merge queue May 19, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/merge Run full CI suite (all OSes) — equivalent to merge queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant