credentials: Restore DefaultDependencies=no for virtiofs#208
Open
gursewak1997 wants to merge 1 commit intomainfrom
Open
credentials: Restore DefaultDependencies=no for virtiofs#208gursewak1997 wants to merge 1 commit intomainfrom
gursewak1997 wants to merge 1 commit intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request restores DefaultDependencies=no for the virtiofs systemd mount unit to fix a mount ordering issue. The changes also include other standard systemd mount unit directives like Conflicts and updating Before, which are good practices. The documentation has been updated accordingly. I've left one minor suggestion to fully sync the documentation with the code changes for better maintainability. Overall, this is a good fix.
Commit be88173 removed DefaultDependencies=no which delayed mount ordering and broke test_run_ephemeral_with_instancetype in CI. Restore explicit dependencies while keeping remote-fs.target. Signed-off-by: gursewak1997 <gursmangat@gmail.com>
gursewak1997
force-pushed
the
fix-execute-virtio-ordering
branch
from
f63feae to
e7c0efe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit be88173 removed DefaultDependencies=no which delayed mount ordering and broke
test_run_ephemeral_with_instancetypein CI. Restore explicit dependencies while keeping remote-fs.target.