Introduce allow-missing-fsverity parameter
#205
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new --disable-fs-verity command-line parameter. However, this flag introduces a security risk by allowing the core fs-verity feature to be disabled, potentially compromising file integrity and authenticity. There is also a suggestion to improve the clarity of the help text for this new parameter.
Johan-Liebert1
force-pushed
the
disable-fsverity
branch
from
e214fd7 to
2db0e62
Compare
Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>
Johan-Liebert1
force-pushed
the
disable-fsverity
branch
from
2db0e62 to
3d03f3e
Compare
Johan-Liebert1
changed the title
disable-fs-verity parameterallow-missing-fsverity parameter
|
|
||
| /// Allow installation without fs-verity support for composefs-native | ||
| /// backend | ||
| #[clap(long, requires = "composefs_backend")] |
There was a problem hiding this comment.
I think we can allow this option for the ostree backend too...even if it's implicitly true by default?
There was a problem hiding this comment.
We could, but it's not really used though in the ostree case. Would be a bit confusing for someone new imo
|
Welp, CI seems to have timed out after 6 hours, which is too long of a timeout. Could someone please restart this as I don't have prems to |
2 participants
No description provided.