README.md: Update libvirt examples #151
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request does a great job of updating the libvirt examples in the README.md. It fixes a non-working example for Fedora images and introduces more practical scenarios, such as using local images and the --update-from-host flag. These changes significantly improve the documentation's utility for new users. I have a couple of suggestions to further enhance clarity and comprehensiveness.
|
|
||
| # Run VM with port forwarding and volume mounts | ||
| bcvk libvirt run --name web-server --port 8080:80 --volume /host/data:/mnt/data quay.io/centos-bootc/centos-bootc:stream10 | ||
| # This example forwards a port and bind mounts content from the host |
There was a problem hiding this comment.
The comment mentions "bind mounts", which could be confusing as there is a separate --bind flag for automatic mounting. This example uses --volume, which creates a virtiofs share that requires manual mounting in the guest. To avoid confusion, it would be clearer to refer to this as a "volume mount". The previous comment was more accurate and less ambiguous.
| # This example forwards a port and bind mounts content from the host | |
| # Run VM with port forwarding and volume mounts |
cgwalters
force-pushed
the
update-readme-libvirt
branch
from
24d60c7 to
3377934
Compare
The first one didn't work because the default Fedora image requires specifying a filesystem. See https://gitlab.com/fedora/bootc/docs/-/merge_requests/141 for improved docs on that. Expand on some other bits too. Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
update-readme-libvirt
branch
from
3377934 to
dbfe231
Compare
2 participants
The first one didn't work because the default Fedora image requires specifying a filesystem. See
https://gitlab.com/fedora/bootc/docs/-/merge_requests/141 for improved docs on that.