ephemeral: Avoid double mounting #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may fix a failure Robert was seeing with a submount in `/usr`. But in general this is just cleaner anyways to avoid a double mount. Signed-off-by: Colin Walters <walters@verbum.org>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the mounting of the host's /usr directory in the ephemeral environment. By moving the mount operation from the entrypoint.sh script to a direct podman volume mount argument, it avoids a "double mount" scenario. This change simplifies the setup, makes it cleaner, and is correctly implemented across both the Rust code and the shell script. The new approach is more robust, and the updated idempotency check in entrypoint.sh is a good improvement. The changes look good.
jeckersb
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may fix a failure Robert was seeing with a submount in
/usr. But in general this is just cleaner anyways to avoid a double mount.