Add a check for required binaries #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
cgwalters
commented
Nov 11, 2025
cgwalters
commented
- We require bwrap in the target container currently, make that clear. That needs to be done in the entrypoint shell script.
- Once we're past that we're in Rust, so add infrastructure to verify that we have systemctl also; this list will be extended in the future
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces checks for required binaries, which is a great improvement for robustness. The check for bwrap in the entrypoint script and systemctl in the Rust code will help users by failing early if dependencies are missing. The implementation is clear and correct. I have one suggestion to make the Rust code for checking binaries more idiomatic by using an iterator-based approach. Overall, a solid contribution.
jeckersb
approved these changes
Nov 11, 2025
- We require bwrap in the target container currently, make that clear. That needs to be done in the entrypoint shell script. - Once we're past that we're in Rust, so add infrastructure to verify that we have systemctl and objcopy for the UKI extraction. Signed-off-by: Colin Walters <walters@verbum.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.