to-disk: Include source imgref in cache hash to prevent incorrect reuse #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Different image references (imgrefs) pointing to the same digest should not share cached disk images, because the source imgref determines the upgrade source for the installed system. Add the `source_imgref` field to the cache metadata structures and include it in the cache hash computation. Additionally, add a `--dry-run` flag to `to-disk` that prints whether the disk would be regenerated (`would-regenerate`) or reused (`would-reuse`) without actually creating it. This is useful for testing and scripting. Closes: bootc-dev#138 Assisted-by: Claude Code (Sonnet 4.5) Signed-off-by: Colin Walters <walters@verbum.org>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly addresses an issue with cache invalidation by including the source image reference in the cache hash. This prevents incorrect cache reuse when different tags point to the same image digest. The addition of the --dry-run flag is also a valuable feature for testing and scripting. The new integration test properly validates the fix. I have one suggestion to refactor a block of code to improve its clarity and maintainability.
jeckersb
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different image references (imgrefs) pointing to the same digest should not share cached disk images, because the source imgref determines the upgrade source for the installed system.
Add the
source_imgreffield to the cache metadata structures and include it in the cache hash computation.Additionally, add a
--dry-runflag toto-diskthat prints whether the disk would be regenerated (would-regenerate) or reused (would-reuse) without actually creating it. This is useful for testing and scripting.Closes: #138
Assisted-by: Claude Code (Sonnet 4.5)