fix: rename SARIF fingerprint key to avoid GitHub warning (#387)#420
Open
Arthaudcom wants to merge 1 commit intoboostsecurityio:mainfrom
Open
fix: rename SARIF fingerprint key to avoid GitHub warning (#387)#420Arthaudcom wants to merge 1 commit intoboostsecurityio:mainfrom
Arthaudcom wants to merge 1 commit intoboostsecurityio:mainfrom
Conversation
…ityio#387) Signed-off-by: Arthaud <arthaudmorin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hi I'm Arthaud Morin, a student from ETS, we met at the midi pizza a month ago. I had free time so I thought why not fix this issue. :)
This PR resolves issue #387 where uploading the Poutine SARIF report to GitHub Code Scanning resulted in an "inconsistent fingerprint value" warning.
Cause: Poutine was hardcoding the
primaryLocationLineHashin the SARIFpartialFingerprintsobject. GitHub'supload-sarifaction expects to calculate this specific hash itself using its own algorithm. When the values don't match, GitHub throws a warning.Fix:
I renamed the key from
primaryLocationLineHashtopoutineFingerprint.This allows Poutine to keep exposing its internal fingerprint logic for other CI/CD integrations that might rely on it, while stepping out of GitHub's reserved keys space. GitHub will now silently and correctly compute its own line hash.
I also added anti-regression assertions in the tests to ensure
primaryLocationLineHashis no longer emitted andpoutineFingerprintis present.Fixes #387
Type of change