Conversation
git commit -m "Progress on home page—some components still need adjustment."
Collaborator
|
@DrJfrost can we get a description with screenshots and testing notes on this? If it's not ready for review, please make it draft. |
Closed
julhoang
requested changes
Apr 14, 2026
Collaborator
julhoang
left a comment
There was a problem hiding this comment.
Hi @herzog0! I'm mostly requesting change for the unintended layout update to the (seemingly) the base template since it happens across a lot of pages:
Some other UI issues for the individual components that I noticed – totally feel free to document them as separate bugs ticket if you feel like they are out of scope:
Collaborator
|
Thanks @julhoang, fixed them all! |
julhoang
reviewed
Apr 16, 2026
julhoang
reviewed
Apr 16, 2026
julhoang
reviewed
Apr 16, 2026
Collaborator
julhoang
left a comment
There was a problem hiding this comment.
This is looking great, thanks for all the updates Teo!! I just noticed 1 more UI issue, otherwise LGTM 🙏
julhoang
approved these changes
Apr 16, 2026
Collaborator
julhoang
left a comment
There was a problem hiding this comment.
woop I meant to add a pre-approval ^ up there
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Issue: #2125
Summary & Context
Changes
V3HomepageViewand registers the/v3/homepage/URL.v3/homepage.htmltemplate, assembling a comprehensive homepage using existing V3 UI components and a new masonry layout.SharedResourcesclass incore/views.pyto consolidate and share demo content data (e.g., posts, events, install options, testimonials) used byV3ComponentDemoViewandV3HomepageView.V3ComponentDemoViewto utilize the newSharedResourcesclass, removing duplicate data definitions and promoting reusability.v3-homepage.css) andjoin-cardcomponents (join-card.css).base.htmlto_v3_example_section.htmlto improve organization.Please list any potential risks or areas that need extra attention during review/testing
Screenshots
Self-review Checklist
Frontend