Skip to content

Story #2125: Homepage component#2193

Merged
herzog0 merged 65 commits intodevelopfrom
homepage-componente
Apr 16, 2026
Merged

Story #2125: Homepage component#2193
herzog0 merged 65 commits intodevelopfrom
homepage-componente

Conversation

@DrJfrost
Copy link
Copy Markdown
Collaborator

@DrJfrost DrJfrost commented Mar 13, 2026

Issue: #2125

Summary & Context

Changes

  • Adds V3HomepageView and registers the /v3/homepage/ URL.
  • Creates the v3/homepage.html template, assembling a comprehensive homepage using existing V3 UI components and a new masonry layout.
  • Introduces SharedResources class in core/views.py to consolidate and share demo content data (e.g., posts, events, install options, testimonials) used by V3ComponentDemoView and V3HomepageView.
  • Updates V3ComponentDemoView to utilize the new SharedResources class, removing duplicate data definitions and promoting reusability.
  • Adds new styling for homepage-specific layouts (v3-homepage.css) and join-card components (join-card.css).
  • Includes various minor UI and responsiveness fixes for existing V3 components, particularly hero sections and different card types.
  • Relocates hero component examples from base.html to _v3_example_section.html to improve organization.

‼️ Risks & Considerations ‼️

Please list any potential risks or areas that need extra attention during review/testing

Screenshots

Self-review Checklist

  • Tag at least one team member from each team to review this PR
  • Link this PR to the related GitHub Project ticket

Frontend

  • UI implementation matches Figma design
  • Tested in light and dark mode
  • Responsive / mobile verified
  • Accessibility checked (keyboard navigation, etc.)
  • Ensure design tokens are used for colors, spacing, typography, etc. – No hardcoded values
  • Test without JavaScript (if applicable)
  • No console errors or warnings

@DrJfrost DrJfrost requested review from fromagge, gregjkal and julhoang and removed request for fromagge March 16, 2026 22:30
Base automatically changed from v3 to develop March 18, 2026 20:41
@gregjkal
Copy link
Copy Markdown
Collaborator

gregjkal commented Mar 20, 2026

@DrJfrost can we get a description with screenshots and testing notes on this?

If it's not ready for review, please make it draft.

@herzog0 herzog0 linked an issue Apr 2, 2026 that may be closed by this pull request
@herzog0 herzog0 marked this pull request as draft April 2, 2026 17:12
@herzog0 herzog0 self-requested a review April 14, 2026 15:02
Copy link
Copy Markdown
Collaborator

@julhoang julhoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @herzog0! I'm mostly requesting change for the unintended layout update to the (seemingly) the base template since it happens across a lot of pages:

Image

Some other UI issues for the individual components that I noticed – totally feel free to document them as separate bugs ticket if you feel like they are out of scope:

Screenshot Notes
Image This card has a border shadow that should be removed, the border radius should be 12px instead of 16px.
Image Some of the data bars are cropped out of view on mobile, maybe we should ask Design if we can add a scrollbar here.
Image On tablet, this last row should have equal-width columns
Image On mobile, this card body should also have equal-width columns

Comment thread static/css/v3/post-cards.css Outdated
Comment thread core/views.py Outdated
@herzog0
Copy link
Copy Markdown
Collaborator

herzog0 commented Apr 14, 2026

Thanks @julhoang, fixed them all!

@herzog0 herzog0 requested a review from julhoang April 14, 2026 18:24
Copy link
Copy Markdown
Collaborator

@julhoang julhoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @herzog0 ! Sorry I have another piece of feedback down below – didn't really think of it in the last round 😅

Comment thread config/urls.py Outdated
@herzog0 herzog0 requested a review from julhoang April 15, 2026 17:25
Comment thread templates/v3/homepage.html Outdated
Comment thread static/css/v3/components.css Outdated
@herzog0 herzog0 requested a review from julhoang April 16, 2026 22:46
Copy link
Copy Markdown
Collaborator

@julhoang julhoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great, thanks for all the updates Teo!! I just noticed 1 more UI issue, otherwise LGTM 🙏

Comment thread static/css/v3/join-card.css Outdated
Copy link
Copy Markdown
Collaborator

@julhoang julhoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woop I meant to add a pre-approval ^ up there

@herzog0 herzog0 merged commit 2564db7 into develop Apr 16, 2026
2 checks passed
@herzog0 herzog0 deleted the homepage-componente branch April 16, 2026 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Webpage UI: Homepage

5 participants