Skip to content

Conversation

@kashish2710
Copy link

This PR adds a regression test case for Boost.Geometry issue #1439.

– Introduces case_1439 in overlay_cases.hpp
– The case represents two non-overlapping polygons
– This case is intended to be used by set operation tests

No algorithm behavior is changed; this only adds test data.

@kashish2710
Copy link
Author

This PR adds the overlay regression case for issue #1439.

Copy link
Collaborator

@barendgehrels barendgehrels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Member

@vissarion vissarion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am OK, I left only some minor comments. Thanks @kashish2710 !
Feel free to merge your commits into one. In any case we can still squash merge the PR.

@kashish2710
Copy link
Author

Thanks @vissarion for the review and suggestions!
I’ve renamed the test to issue_1439, fixed the indentation, and removed the redundant comment.
Appreciate the feedback. 🚀

Copy link
Collaborator

@tinko92 tinko92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants