-
Notifications
You must be signed in to change notification settings - Fork 228
Add overlay regression case for issue 1439 #1444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
This PR adds the overlay regression case for issue #1439. |
barendgehrels
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
vissarion
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am OK, I left only some minor comments. Thanks @kashish2710 !
Feel free to merge your commits into one. In any case we can still squash merge the PR.
|
Thanks @vissarion for the review and suggestions! |
tinko92
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
This PR adds a regression test case for Boost.Geometry issue #1439.
– Introduces case_1439 in overlay_cases.hpp
– The case represents two non-overlapping polygons
– This case is intended to be used by set operation tests
No algorithm behavior is changed; this only adds test data.