Conversation
Get OpenCL headers, libraries, and runtime from somewhere more reliable. Added VS2017 configuration to the matrix.
Updated CMake v3.10 -> v3.13 Updated pocl v1.0 -> v1.2 Updated GCC v4.8/v5 -> v6 Updated LLVM v5.0.1 -> v6.0.1 Updated Boost v1.65.1 -> v1.67.0 Fixed OpenCL header download Fixed AMDAPPSDK installation
|
I'll take a look at it. I'm actually also working on fixing/changing Travis CI script (see https://github.com/jszuppe/compute/tree/fix_travis_ci), but I'll definitely include what you did with AppVeyor if it works ok. I'll be doing this during the week, I should finish in the weekend. |
|
I was thinking about removing AMD APP SDK, which is deprecated, and using Intel OpenCL instead. |
Boost, LLVM, Clang, and GCC, have also been updated.
|
Please clean caches and re-run CI. The remaining failures are warnings being treated as errors, I think. |
|
Ok, ignoring the warnings still doesn't make all tests pass. But everything else seems to be working. |
|
Do you want me to do a rebase and include only the appveyor changes? |
You can do separate PR for that. As for |
|
Here's something you might be interested in checking out. Is that behavior on the Ubuntu images expected? I'll open a PR with a windows only appveyor config. |
|
If you mean the compilation error on 18.04 (in general when using g++ >=6), then I'll be looking into this after adding Intel Platform 2.0 and 2.1 tests to Travis CI script. If you mean the problem on 16.04, then it's the first time I see it. |
|
btw. Have you looked into using Windows on Travis CI? |
Changes extracted from PR boostorg#804
|
I have checked it out in the past, but it was still pretty green. Here's something I just cobbled up together https://travis-ci.com/Zialus/compute/builds/95828633 |
Changes extracted from PR boostorg#804
They take way too long to build though.
1ba9a9c to
696ab7a
Compare
|
I think you can close this PR and open two new PR for your changes regarding OSX and Windows that would be based on current |
|
I might try that tomorrow. Is there a reason appveyor isn't getting triggered with the new commits? |
Webhook stopped working and I don't have access to add it. |
|
Just to be clear, for this new PR should I branch of from |
|
Yes. When there are already changes in develop that would cause a conflicts it's better to base changes on develop. |
This should make all the current configuration on appveyor and travis build and pass the tests.
I've added two extra configs. VS2017 on Windows and GCC on OSX.
There's a warning while using GCC on OSX that is triggering -Werror and causing that particular setup to fail. I'm not sure if that is expected behaviour.